[tool] add SimTool interface and implementations #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machshev
force-pushed
the
tool_plugin
branch
7 times, most recently
from
a52eff3 to
72c67a1
Compare
`sim_tools` module contains functions that provide tool support. This commit adds a `SimTool` `Protocol`, which clearly defines the functions required to support an EDA tool in DVSim. The functions found within the `sim_tools` module have been moved to vendor specific modules containing a `SimTool` implementation. Supported plugins can be retrieved with the `get_sim_tool_plugin` function. `sim_tools` has been refactored to use the plugin. Signed-off-by: James McCorrie <[email protected]>
Signed-off-by: James McCorrie <[email protected]>
Signed-off-by: James McCorrie <[email protected]>
machshev
force-pushed
the
tool_plugin
branch
from
72c67a1 to
7641798
Compare
Collaborator
Author
|
Locally generated report. 
|
I assume this dataset was without coverage results (because they are missing in the graphic) |
gautschimi
approved these changes
Nov 13, 2025
gautschimi
left a comment
gautschimi
left a comment
There was a problem hiding this comment.
I think it's much cleaner, and could be easily extended for another tool.
|
Nice to have:
I think it used to be like this |
Signed-off-by: James McCorrie <[email protected]>
machshev
force-pushed
the
tool_plugin
branch
from
0e79518 to
b3ff5ba
Compare
Collaborator
Author
|
hcallahan-lowrisc
approved these changes
Nov 13, 2025
Contributor
hcallahan-lowrisc
left a comment
hcallahan-lowrisc
left a comment
There was a problem hiding this comment.
LGTM, this is much more structured.
Collaborator
Author
|
Thanks! Merging this now as I'd like to get it in before the nightly runs this evening... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the EDA tool support utilities into a more structured plug-in system, with clearly defined interface to make it easier to implement further tool support and test the existing tool support.
sim_toolsmodule to use the new plug-ins.Fixes: #55